socket: consistency between constants and enums #8099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2022 00:01
This matches what happens at runtime, from Enum._convert_ Helps with python#8098
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Jun 19, 2022
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Jun 19, 2022
Fixes python#8098 (along with python#8099)
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
approved these changes
Jun 19, 2022
hauntsaninja
added a commit
that referenced
this pull request
Jun 19, 2022
AlexWaygood
added a commit
that referenced
this pull request
Jun 19, 2022
Slipped through the net in #8099
AlexWaygood
added a commit
that referenced
this pull request
Jun 19, 2022
Slipped through the net in #8099
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches what happens at runtime, from
Enum._convert_Helps with #8098. Fixes #5696.