Add types for zxcvbn

[srittau]

No description provided.

[AlexWaygood]

Mostly looks good, but I'm not sure about the huge _Match TypedDict in matching.pyi. It seems like we could probably have a smaller base TypedDict, and return subtypes of that TypedDict from specific functions where _Match always has certain other keys.

[srittau]

Mostly looks good, but I'm not sure about the huge _Match TypedDict in matching.pyi. It seems like we could probably have a smaller base TypedDict, and return subtypes of that TypedDict from specific functions where _Match always has certain other keys.

Basically everything except the zxcvbn() function in __init__.py is internal API anyway, so I wouldn't want to put the work in for a finer-grained API.

[srittau]

Ideally we'd be able to return DateMatch | DictionaryMatch | ..., but I don't think type checkers support discriminating result by typed dict field (pattern in this case).

[AlexWaygood]

What do you want to do here?

1. Wait until pyre/pytype have PEP 655 support?
2. Rewrite the PR to use TypedDict inheritance for now?
3. YOLO it and go with PEP 655 even though pytype/pyre don't fully support it yet?

[srittau]

I honestly think, we could just merge it. pytype should just assume Any if I understand pytype's type handling correctly. We can wait for pyre support, but on the other hand this is a new package, so it not working for a few weeks is not a regression.

[JelleZijlstra]

A few small comments

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉