Skip to content

Add stubs for dj-database-url #7972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2022
Merged

Conversation

XF-FW
Copy link
Contributor

@XF-FW XF-FW commented May 28, 2022

Adds stubs for https://github.com/jazzband/dj-database-url/

Thanks to @sbdchd for providing a great starting point here: chdsbd/kodiak#559 .

This will also close: jazzband/dj-database-url#135

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just two comments

@Qu4tro Qu4tro force-pushed the dj-database-url branch from 048ed6b to b447eba Compare May 28, 2022 14:05
@Qu4tro Qu4tro force-pushed the dj-database-url branch from b447eba to 93c1bfc Compare May 28, 2022 14:06
@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood merged commit 3191c1a into python:master May 28, 2022
@palfrey
Copy link
Contributor

palfrey commented Jun 1, 2022

The TypedDict for this only has the fields for dj-database-url, not the rest of them. Even with the total=False setting, I still get error: Extra key "TEST" for TypedDict "_DBConfig" out of mypy when trying to set the TEST setting later on.

@AlexWaygood
Copy link
Member

AlexWaygood commented Jun 1, 2022

The TypedDict for this only has the fields for dj-database-url, not the rest of them. Even with the total=False setting, I still get error: Extra key "TEST" for TypedDict "_DBConfig" out of mypy when trying to set the TEST setting later on.

Thanks! Feel free to submit a PR improving the situation :)

@XF-FW
Copy link
Contributor Author

XF-FW commented Jun 1, 2022

Yeah, I had mentioned it here: #7979 (comment)

Like Alex mentioned, feel free to do a PR, otherwise, I'll take care of it, sometime next week.

@palfrey
Copy link
Contributor

palfrey commented Jun 1, 2022

The TypedDict for this only has the fields for dj-database-url, not the rest of them. Even with the total=False setting, I still get error: Extra key "TEST" for TypedDict "_DBConfig" out of mypy when trying to set the TEST setting later on.

Thanks! Feel free to submit a PR improving the situation :)

#8008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding type hints
4 participants