Skip to content

contextlib: Remove explicit base class from ExitStack #7963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2022
Merged

contextlib: Remove explicit base class from ExitStack #7963

merged 2 commits into from
May 27, 2022

Conversation

JelleZijlstra
Copy link
Member

Fixes #7961

@JelleZijlstra JelleZijlstra marked this pull request as ready for review May 27, 2022 04:44
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra changed the title Remove explicit base class from ExitStack contextlib: Remove explicit base class from ExitStack May 27, 2022
AlexWaygood
AlexWaygood approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks great to me.

@JelleZijlstra JelleZijlstra merged commit c35ec8b into python:master May 27, 2022
@JelleZijlstra JelleZijlstra deleted the contextlib branch May 27, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong return type from ExitStack.enter_context when given a child of ExitStack
2 participants
@JelleZijlstra @AlexWaygood