Skip to content

Fix logging.Logger.isEnabledFor() to return bool instead of None. #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2016
Merged

Fix logging.Logger.isEnabledFor() to return bool instead of None. #716

merged 1 commit into from
Nov 28, 2016

Conversation

tetron
Copy link
Contributor

@tetron tetron commented Nov 28, 2016

No description provided.

@tetron
Copy link
Contributor Author

tetron commented Nov 28, 2016

On further inspection, in Python 2.7 at least, isEnabledFor() can return either zero or a boolean. Updated to reflect that.

@ambv ambv merged commit d0f6a05 into python:master Nov 28, 2016
@ambv
Copy link
Contributor

ambv commented Nov 28, 2016

Technically the int is only used on Python 2 but it's splitting hairs to copy the stubs just for that one method alone. Thanks for your contribution!

ambv pushed a commit that referenced this pull request Nov 29, 2016
logging.Formatter attributes fixed
dbdb63c 
Fixes #720.

Related changes: used a NamedTuple for time.struct_time on Python 3, used
sys.version selectors for proper typing of #716, added missing *Style classes
to logging on Python 3.
@ambv ambv mentioned this pull request Nov 29, 2016
Merged
ambv pushed a commit that referenced this pull request Nov 29, 2016
logging.Formatter attributes fixed
be51158 
Fixes #720.

Related changes: used a NamedTuple for time.struct_time on Python 3, used
sys.version selectors for proper typing of #716, added missing *Style classes
to logging on Python 3.
ambv pushed a commit that referenced this pull request Nov 30, 2016
logging.Formatter attributes fixed
a58790e 
Fixes #720.

Related changes: used a NamedTuple for time.struct_time on Python 3, used
sys.version selectors for proper typing of #716, added missing *Style classes
to logging on Python 3.
@ambv ambv mentioned this pull request Nov 30, 2016
Closed
gvanrossum pushed a commit that referenced this pull request Nov 30, 2016
@ambv @gvanrossum
logging.Formatter attributes fixed (#721)
85807ed 
Fixes #720.

Related changes: used a NamedTuple for time.struct_time on Python 3, used
sys.version selectors for proper typing of #716, added missing *Style classes
to logging on Python 3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tetron @ambv