-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Delete many redundant method redefinitions #6877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
2288a0f
d1a47f9
3d3937b
c6aee27
7cb8c86
7fcb24a
1b021f0
321ac83
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,13 +31,11 @@ _MAX_WINDOWS_WORKERS: int | |
class _RemoteTraceback(Exception): | ||
tb: str | ||
def __init__(self, tb: TracebackType) -> None: ... | ||
def __str__(self) -> str: ... | ||
|
||
class _ExceptionWithTraceback: | ||
exc: BaseException | ||
tb: TracebackType | ||
def __init__(self, exc: BaseException, tb: TracebackType) -> None: ... | ||
def __reduce__(self) -> str | tuple[Any, ...]: ... | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not 100% sure about this since I could imagine a type checker checking whether an object can be pickled safely and checking There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You've changed your tune ;) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess I just default to not making changes when we don't have a clear reason for change :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A sound policy. |
||
|
||
def _rebuild_exc(exc: Exception, tb: str) -> Exception: ... | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.