Add @final
to many unsubclassable stdlib classes
#6299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were all discovered using the following extremely crude script, the output of which I then manually checked:
The only results that this script produced that I have not added
@final
to aredict_keys
,dict_values
anddict_items
(exposed incollections.abc
at runtime, and inbuiltins
in typeshed). I couldn't add@final
to these classes because of the following weirdness:So, while these classes are not subclassable at runtime, they nonetheless have subclasses in the stdlib, meaning mypy understandably complains if I try to add
@final
to them.