Fix various typos #6263
Merged
Fix various typos #6263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found via `codespell -q 3 -L alo,asend,ba,nams,spawnve` Originally found downstream python/mypy#11498 (comment)
|
API changes in 4da3ef5 |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
Thanks! You'll want to walk back the API changes, until the actual packages have changed them and made releases with the changes. The caldav one seems fixed on master, but is unreleased: python-caldav/caldav@17ce149#diff-b555f28986a83b009effbdd857352e16a2efd9407704f09477a2c844e8badbe0 |
stubs/PyYAML/yaml/emitter.pyi
Outdated
| column: Any | ||
| whitespace: Any | ||
| indention: Any | ||
| indentation: Any |
There was a problem hiding this comment.
This is what it's actually called in pyyaml (at least as of version 6.0), so we can't change this. Same for the other change in this file.
stubs/caldav/caldav/lib/error.pyi
Outdated
| class NotFoundError(DAVError): ... | ||
| class ConsistencyError(DAVError): ... | ||
| class ReponseError(DAVError): ... | ||
| class ResponseError(DAVError): ... |
There was a problem hiding this comment.
Similarly, this really is called ReponseError in caldav. I think it's worth adding a comment here in case a future reader is confused.
This reverts commit 4da3ef5.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via
codespell -q 3 -L alo,asend,ba,nams,spawnveOriginally found downstream python/mypy#11498 (comment)