Improve the annotations of types.MappingProxyType
#5822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 30, 2021 14:19
* `__hash__` * `__reversed__` * `__class_getitem__`
The assumption here is that the underlying mapping is a `dict`, just is done for `MappingProxyType.copy`
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
Not directly related to your PR, but something I noticed: The value type of |
Co-Authored-By: Sebastian Rittau <[email protected]>
Might as well while we're at it; done as of 4a864e9. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the annotations of
MappingProxyTypein the following two manners:The second set of changes uses the same assumption that was made for its
copymethod (xref #4510):that the underlying mapping is a dictionary.
Just as with
MappingProxyType.copythis assumption is not guaranteed to always be true,but it will result in an improvement for the majority of cases (e.g. #5808 once its return type has been fixed)