Update protobuf generated stubs from mypy-protobuf 2.8 #5804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/generate_proto_stubs.sh
Outdated
| @@ -73,3 +73,5 @@ protoc_install/bin/protoc --proto_path=$PYTHON_PROTOBUF_DIR/src --mypy_out=$REPO | |||
|
|
|||
| isort $REPO_ROOT/stubs/protobuf | |||
| black $REPO_ROOT/stubs/protobuf | |||
|
|
|||
| sed -i="" 's/mypy-protobuf [^"]*/mypy-protobuf 2.8/' $REPO_ROOT/stubs/protobuf/METADATA.toml | |||
There was a problem hiding this comment.
Maybe just put ${MYPY_PROTOBUF_VERSION} here?
There was a problem hiding this comment.
oops! Thanks for catching
There was a problem hiding this comment.
You need to switch to double quotes, because variables aren't substituted inside single quotes. But then you need to escape the double quote in the regex:
Suggested change
| sed -i="" 's/mypy-protobuf [^"]*/mypy-protobuf 2.8/' $REPO_ROOT/stubs/protobuf/METADATA.toml | |
| sed -i="" "s/mypy-protobuf [^\"]*/mypy-protobuf 2.8/" $REPO_ROOT/stubs/protobuf/METADATA.toml |
I think I got it right, but I'm not sure. Make sure to try it.
There was a problem hiding this comment.
Yep @Akuli is right - I had to make that exact change.
nipunn1313
force-pushed
the
bump_to_mypy_protobuf_28
branch
from
149eec3 to
657ebbb
Compare
JelleZijlstra
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes features from 2.7 and 2.8
https://github.com/dropbox/mypy-protobuf/blob/master/CHANGELOG.md
Notably