Fixing timezone utc type #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #567.
I couldn't figure out how to get pytype running, but the mypy tests are passing. I couldn't find anything to add a regression test to? I was able to run mypy with the updated stubs on some similar syntax to the original ticket, and everything seemed to pass.
For 2.7, It's looking like they didn't have a timezone type (https://docs.python.org/2/library/datetime.html)? I took a shot at removing timezone types in the PR, too, but if that's get's more complicated, I can remove it from the PR, and we can just get 3 working.