Skip to content

use protocol for sys.meta_path #5349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2021
Merged

use protocol for sys.meta_path #5349

merged 2 commits into from
May 6, 2021

Conversation

Akuli
Copy link
Collaborator

@Akuli Akuli commented May 6, 2021

Fixes #5276

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why pytype explodes, but LGTM.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

Diff from mypy_primer, showing the effect of this PR on open source code:

alerta (https://github.com/alerta/alerta.git)
+ alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

Diff from mypy_primer, showing the effect of this PR on open source code:

alerta (https://github.com/alerta/alerta.git)
+ alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)
- alerta/models/alarms/isa_18_2.py:10: error: Library stubs not installed for "flask" (or incompatible with Python 3.8)

@Akuli Akuli merged commit bb5fb84 into python:master May 6, 2021
@Akuli Akuli deleted the metapath branch May 6, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sys.meta_path has incorrect type
2 participants