Use protocols for gzip and _compression #5170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
commented
Apr 1, 2021
| compresslevel: int = ..., | ||
| fileobj: Optional[IO[bytes]] = ..., | ||
| fileobj: Union[_ReadableFileobj, _WritableFileobj, None] = ..., | ||
| mtime: Optional[float] = ..., | ||
| ) -> None: ... |
There was a problem hiding this comment.
It's possible to add more overloads to check filename/fileobj, but that could be done in a separate PR.
This comment has been minimized.
This comment has been minimized.
|
It's a bit strange that the mypy_primer run after the last PR shows no diff. I'd have expected the scrapy warnings to still be present (they point to a genuine problem), same with the now obsolete |
Akuli
reviewed
Apr 2, 2021
Comment on lines
126
to
+128
| mode: Optional[str] = ..., | ||
| compresslevel: int = ..., | ||
| fileobj: Optional[IO[bytes]] = ..., | ||
| fileobj: Union[_ReadableFileobj, _WritableFileobj, None] = ..., |
There was a problem hiding this comment.
This overload allows basically anything for mode and fileobj, including invalid combinations, such as "w" with a readable file object. Ideally there would be a way to say "use this overload only if mode is not a Literal", but I don't think there's anything like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5099