PEP 604: Add or operator to class type #5150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas.git)
+ pandas/core/generic.py:11131: error: unused 'type: ignore' comment
|
Akuli
reviewed
Mar 29, 2021
| @@ -156,6 +156,7 @@ class type(object): | |||
| def __subclasscheck__(self, subclass: type) -> bool: ... | |||
| @classmethod | |||
| def __prepare__(metacls, __name: str, __bases: Tuple[type, ...], **kwds: Any) -> Mapping[str, Any]: ... | |||
| def __or__(self, t: type) -> type: ... | |||
There was a problem hiding this comment.
You could wrap this inside if sys.version_info >= (3, 10)
There was a problem hiding this comment.
Yes, I forgot about it and decided to close pr. I'll do it and create new one
There was a problem hiding this comment.
You can also change a pull request by pushing more commits to your branch.
There was a problem hiding this comment.
Ok, next time I will do this way
|
Replaced by #5151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.10 allowing writing union types as X | Y so class
typenow should have operator or