Run pyright on matrix of platforms and python versions #5072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
force-pushed
the
pyright-2
branch
from
057a3de to
60d30fa
Compare
|
I added 3.10 as pyright supports some of the upcoming features, but it seems like typeshed is missing a few things (which are probably stub conditional bugs). I'll remove that. |
|
#5070 includes a fix for the lone failure in 3.6. |
JelleZijlstra
approved these changes
Feb 25, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyright 1.1.115 has flags to specify the platform and python version. This modifies the wrapper script to pass argv through and adds the matrix to the workflow.
I'm not sure how "good" it is to run a big matrix like this, but they only take a few seconds each.