paramiko: get_banner in transport returns bytes #4974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_banner in paramiko.transport returns bytes and not str. (That's for Python 3, not sure how Python 2 & 3 should be supported together?)
srittau
approved these changes
Jan 26, 2021
|
|
|
I thought we agreed that we will not merge anything this week. This (and the second merged PR) now create conflicts with #4971. Although it is not hard to fix, it would be easier for me to not be distracted by this. |
|
I am sorry, I didn't realize the restructuring was already in the moving phase. I will stop merging any more PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_banner in paramiko.transport returns bytes and not str. (That's for Python 3, not sure how Python 2 & 3 should be supported together?)