itertools: fix signature of accumulate #4933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 13, 2021 20:54
srittau
requested changes
Jan 14, 2021
stdlib/3/itertools.pyi
Outdated
Comment on lines
24
to
28
| def accumulate(iterable: Iterable[_T], func: Optional[Callable[[_T, _T], _T]] = ...) -> Iterator[_T]: ... | ||
| @overload | ||
| def accumulate(iterable: Iterable[_T], func: Callable[[_S, _T], _S], initial: Optional[_S]) -> Iterator[_S]: ... | ||
| def accumulate( | ||
| iterable: Iterable[_T], func: Optional[Callable[[_S, _T], _S]] = ..., *, initial: Optional[_S] = ... | ||
| ) -> Iterator[_S]: ... |
There was a problem hiding this comment.
These two overloads seem to overlap. Also, the second overload can't work if func is None, because _S is then undefined. I would suggest to use func: None = ... for the first (which also needs to include initial), and func: Callable[etc] (without default) for the second overload. I think this should also cover all cases?
There was a problem hiding this comment.
Thanks, that looks right to me too
srittau
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4888