Skip to content

Added: None Overload #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Added: None Overload #4722

merged 1 commit into from
Oct 27, 2020

Conversation

utsav00
Copy link
Contributor

@utsav00 utsav00 commented Oct 27, 2020

Solved: #4713

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

+ src/werkzeug/http.py:904: error: No overload variant of "parsedate_tz" matches argument type "str"
+ src/werkzeug/http.py:904: note:     def parsedate_tz(date: None) -> None
+ src/werkzeug/http.py:904: note: Possible overload variant:

+ starlette/staticfiles.py:213: error: No overload variant of "parsedate" matches argument type "str"
+ starlette/staticfiles.py:213: note:     def parsedate(date: None) -> None
+ starlette/staticfiles.py:213: note: Possible overload variant:
+ starlette/staticfiles.py:214: error: No overload variant of "parsedate" matches argument type "str"
+ starlette/staticfiles.py:214: note:     def parsedate(date: None) -> None
+ starlette/staticfiles.py:214: note: Possible overload variant:

+ aiohttp/web_response.py:318: error: No overload variant of "parsedate" matches argument type "str"
+ aiohttp/web_response.py:318: note:     def parsedate(date: None) -> None
+ aiohttp/web_response.py:318: note: Possible overload variant:
+ aiohttp/web_response.py:320: error: "datetime" gets multiple values for keyword argument "tzinfo"
+ aiohttp/web_request.py:474: error: No overload variant of "parsedate" matches argument type "str"
+ aiohttp/web_request.py:474: note:     def parsedate(date: None) -> None
+ aiohttp/web_request.py:474: note: Possible overload variant:
+ aiohttp/web_request.py:476: error: "datetime" gets multiple values for keyword argument "tzinfo"

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@hauntsaninja hauntsaninja merged commit 75a92eb into python:master Oct 27, 2020
@utsav00 utsav00 deleted the add-none-overload branch October 30, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants