Update stub for CodeGeneratorResponse protobuf message #4680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks like one of our flake8 plugins got broken by Python 3.9: #4677 (comment) |
Add Feature enum and supported_features. These are related to the optional proto3 fields introduced in 3.12.0, see https://github.com/protocolbuffers/protobuf/releases/tag/v3.12.0 and https://github.com/protocolbuffers/protobuf/blob/214c77e1b76e63e512bd675d1c300c80438642b6/src/google/protobuf/compiler/plugin.proto#L112
henribru
force-pushed
the
protobuf-code-generator-response-feature
branch
from
6172e22 to
6714f74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Featureenum andsupported_featuresfield to CodeGeneratorResponseThese are related to the optional proto3 fields introduced in 3.12.0, see https://github.com/protocolbuffers/protobuf/releases/tag/v3.12.0 and https://github.com/protocolbuffers/protobuf/blob/214c77e1b76e63e512bd675d1c300c80438642b6/src/google/protobuf/compiler/plugin.proto#L112
Note that I've typed this differently than the stubs for other enums in
google.protobuf. As pointed out in #2521, the current enum stubs are incorrect. I can however change it if you would prefer these stubs to be consistent with the existing ones and fixed together with those at a later point.