Regenerate google.protobuf stubs using mypy-protobuf #4341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that these stubs may not be backward compatible with the old stubs - particularly for enums - where the old stubs were incorrectly conflating the EnumValue (int) with the EnumTypeWrapper - preventing inheritance from the base class EnumTypeWrapper |
|
The build fails du to various reasons and by now the stubs don't apply cleanly anymore. These problem would need to be fixed before we can consider applying this PR. As it stands, it's also hard to see the differences to the manually generated stubs. |
|
Closing per my last comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regenerates the stubs using the latest mypy-protobuf source - fixing a variety of issues - most notably the autogeneration of enums to more closely match google's autogenerated python code.
Fixes #2521