Add a mypy self test #4337
Merged
Add a mypy self test #4337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| shutil.copytree('stdlib', str(dirpath / 'mypy/mypy/typeshed/stdlib')) | ||
| shutil.copytree('third_party', str(dirpath / 'mypy/mypy/typeshed/third_party')) | ||
| try: | ||
| subprocess.run(['pytest', '-n12'], cwd=str(dirpath / 'mypy'), check=True) |
There was a problem hiding this comment.
maybe this should be -n auto?
There was a problem hiding this comment.
I just moved this file from the old mypy_selftest.py. I'd consider changes to it out of scope of this PR.
tests/mypy_selftest.py
Outdated
| try: | ||
| subprocess.run(['pytest', '-n12'], cwd=str(dirpath / 'mypy'), check=True) | ||
| subprocess.run([sys.executable, "-m", "pip", "install", f"mypy=={MYPY_VERSION}"], check=True) | ||
| subprocess.run(["mypy", "--custom-typeshed-dir", ".", dirpath / "mypy", dirpath / "mypyc"], check=True) |
There was a problem hiding this comment.
This doesn't pass for me against mypy master (after removing --custom-typeshed-dir). The command mypy uses is mypy --config-file mypy_self_check.ini -p mypy -p mypyc
There was a problem hiding this comment.
Let's try this config file.
|
Still failing. We'd need to investigate further if we decide that this is a viable way to go forward. |
Rename mypy_selftest to mypy_test_suite
srittau
force-pushed
the
mypy-selftest
branch
from
3d47672 to
933d4fd
Compare
hauntsaninja
force-pushed
the
mypy-selftest
branch
from
d873048 to
e62e357
Compare
hauntsaninja
force-pushed
the
mypy-selftest
branch
from
e62e357 to
7c7d145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename mypy_selftest to mypy_test_suite
Cf. #4333