Skip to content

Improve distutils #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Aug 3, 2016
Merged

Improve distutils #418

merged 21 commits into from
Aug 3, 2016

Conversation

tharvik
Copy link
Contributor

@tharvik tharvik commented Jul 29, 2016

Add the whole distutils hierarchy. Also, merge py2 and py3 version of old stubs.

There is a bunch of empty file, it is because the documentations advertise the module but there isn't any definition in it, so importable but useless (let's respect the doc).

Currently failling because of pytype#30.

@tharvik tharvik force-pushed the improve_distutils branch from 4cf356c to 2e113f8 Compare July 29, 2016 08:52
@matthiaskramm
Copy link
Contributor

We'll export a fix for google/pytype#30 today.

@tharvik
Copy link
Contributor Author

tharvik commented Jul 29, 2016

Nice! I won't be able to update the PR for some days, so feel free to take over.

@matthiaskramm
Copy link
Contributor

Closing and reopening, to force a Travis rebuild.

@matthiaskramm
Copy link
Contributor

Travis is still broken, seems we need to remove some unwarranted # type: ignore directives.

@tharvik
Copy link
Contributor Author

tharvik commented Aug 1, 2016

I rebased it on master, as 4c20cd6 removed the type: ignore in mmap; there is still this issue about having @abstractmethod which isn't supported by pytype, just opened pytype#32.

@tharvik
Copy link
Contributor Author

tharvik commented Aug 2, 2016

pytype#32 is fixed and this part is working, but pytype#33 happened.

@alvarocaceres
Copy link
Contributor

my fault -- a pytype update broke travis.. Will check next time. PR #430 should make travis green...

@tharvik tharvik force-pushed the improve_distutils branch from cf6a6b1 to 4eb2d07 Compare August 2, 2016 14:43
@tharvik tharvik force-pushed the improve_distutils branch from 4eb2d07 to 6808495 Compare August 2, 2016 14:46
@tharvik
Copy link
Contributor Author

tharvik commented Aug 2, 2016

#430 indeed makes it work.

@matthiaskramm matthiaskramm merged commit 2e560d3 into python:master Aug 3, 2016
@tharvik tharvik deleted the improve_distutils branch August 8, 2016 06:47
hswong3i pushed a commit to alvistack/python-typeshed that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants