Skip to content

protobuf: Add Message.FromString static method. #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2019
Merged

protobuf: Add Message.FromString static method. #3327

merged 1 commit into from
Oct 9, 2019

Conversation

benjaminp
Copy link
Contributor

No description provided.

srittau
srittau requested changes Oct 8, 2019
View reviewed changes
@benjaminp benjaminp force-pushed the message-FromString branch 3 times, most recently from 56b7f57 to 02a0154 Compare October 8, 2019 18:53
@srittau
Copy link
Collaborator

srittau commented Oct 8, 2019

I can't see Message.FromString in the current version of the file, at least not in the abc. Where is it defined?

@benjaminp
Copy link
Contributor Author

It's magically added to generated code: https://github.com/protocolbuffers/protobuf/blob/7efcc0466c31e18842d612b1a70cec3f1c9bfb23/python/google/protobuf/internal/python_message.py#L782

@benjaminp
Copy link
Contributor Author

(Documentation here: https://developers.google.com/protocol-buffers/docs/reference/python-generated#message)

@srittau srittau merged commit 50961d4 into python:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminp @srittau