Skip to content

Remove unneeded ignores #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/2/UserString.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ class UserString(Sequence[UserString]):
def __hash__(self) -> int: ...
def __len__(self) -> int: ...
@overload
def __getitem__(self: _UST, i: int) -> _UST: ... # type: ignore
def __getitem__(self: _UST, i: int) -> _UST: ...
@overload
def __getitem__(self: _UST, s: slice) -> _UST: ... # type: ignore
def __getitem__(self: _UST, s: slice) -> _UST: ...
def __add__(self: _UST, other: Any) -> _UST: ...
def __radd__(self: _UST, other: Any) -> _UST: ...
def __mul__(self: _UST, other: int) -> _UST: ...
Expand Down
2 changes: 1 addition & 1 deletion stdlib/2/_io.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class _RawIOBase(_IOBase):
def readall(self) -> str: ...
def read(self, n: int = ...) -> str: ...

class FileIO(_RawIOBase, BytesIO): # type: ignore # for __enter__
class FileIO(_RawIOBase, BytesIO):
mode = ... # type: str
closefd = ... # type: bool
def __init__(self, file: Union[str, int], mode: str = ..., closefd: bool = ...) -> None: ...
Expand Down
4 changes: 2 additions & 2 deletions stdlib/2/os/path.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -137,14 +137,14 @@ if sys.version_info < (3, 0):
elif sys.version_info >= (3, 6):
# Mypy complains that the signatures overlap (same for relpath below), but things seem to behave correctly anyway.
@overload
def join(path: _StrPath, *paths: _StrPath) -> Text: ... # type: ignore
def join(path: _StrPath, *paths: _StrPath) -> Text: ...
@overload
def join(path: _BytesPath, *paths: _BytesPath) -> bytes: ...
else:
def join(path: AnyStr, *paths: AnyStr) -> AnyStr: ...

@overload
def relpath(path: _BytesPath, start: Optional[_BytesPath] = ...) -> bytes: ... # type: ignore
def relpath(path: _BytesPath, start: Optional[_BytesPath] = ...) -> bytes: ...
@overload
def relpath(path: _StrPath, start: Optional[_StrPath] = ...) -> Text: ...

Expand Down
2 changes: 1 addition & 1 deletion stdlib/2/user.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
# Source: https://hg.python.org/cpython/file/2.7/Lib/user.py
from typing import Any

def __getattr__(name) -> Any: ... # type: ignore
def __getattr__(name) -> Any: ...
home: str
pythonrc: str
6 changes: 3 additions & 3 deletions stdlib/2and3/datetime.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,9 @@ class datetime(date):
def __gt__(self, other: datetime) -> bool: ... # type: ignore
def __add__(self, other: timedelta) -> datetime: ...
@overload # type: ignore
def __sub__(self, other: datetime) -> timedelta: ... # type: ignore
@overload # type: ignore
def __sub__(self, other: timedelta) -> datetime: ... # type: ignore
def __sub__(self, other: datetime) -> timedelta: ...
@overload
def __sub__(self, other: timedelta) -> datetime: ...
def __hash__(self) -> int: ...
def weekday(self) -> int: ...
def isoweekday(self) -> int: ...
Expand Down
8 changes: 4 additions & 4 deletions stdlib/3/importlib/machinery.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class BuiltinImporter(importlib.abc.MetaPathFinder,
def get_source(cls, fullname: str) -> None: ...
# Loader
@staticmethod
def module_repr(module: types.ModuleType) -> str: ... # type: ignore
def module_repr(module: types.ModuleType) -> str: ...
@classmethod
def create_module(cls, spec: ModuleSpec) -> Optional[types.ModuleType]: ...
@classmethod
Expand Down Expand Up @@ -62,12 +62,12 @@ class FrozenImporter(importlib.abc.MetaPathFinder, importlib.abc.InspectLoader):
def get_source(cls, fullname: str) -> None: ...
# Loader
@staticmethod
def module_repr(module: types.ModuleType) -> str: ... # type: ignore
def module_repr(module: types.ModuleType) -> str: ...
@classmethod
def create_module(cls, spec: ModuleSpec) -> Optional[types.ModuleType]:
...
@staticmethod
def exec_module(module: types.ModuleType) -> None: ... # type: ignore
def exec_module(module: types.ModuleType) -> None: ...

class WindowsRegistryFinder(importlib.abc.MetaPathFinder):
@classmethod
Expand Down Expand Up @@ -113,4 +113,4 @@ class SourcelessFileLoader(importlib.abc.FileLoader,

class ExtensionFileLoader(importlib.abc.ExecutionLoader):
def get_filename(self, fullname: str) -> importlib.abc._Path: ...
def get_source(self, fullname: str) -> None: ... # type: ignore
def get_source(self, fullname: str) -> None: ...
2 changes: 1 addition & 1 deletion stdlib/3/os/__init__.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ if sys.version_info >= (3, 0):
def popen(command: str, mode: str = ..., buffering: int = ...) -> _wrap_close: ...
else:
class _wrap_close(IO[Text]):
def close(self) -> Optional[int]: ... # type: ignore
def close(self) -> Optional[int]: ...
def popen(__cmd: Text, __mode: Text = ..., __bufsize: int = ...) -> _wrap_close: ...
def popen2(__cmd: Text, __mode: Text = ..., __bufsize: int = ...) -> Tuple[IO[Text], IO[Text]]: ...
def popen3(__cmd: Text, __mode: Text = ..., __bufsize: int = ...) -> Tuple[IO[Text], IO[Text], IO[Text]]: ...
Expand Down
4 changes: 2 additions & 2 deletions stdlib/3/os/path.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -137,14 +137,14 @@ if sys.version_info < (3, 0):
elif sys.version_info >= (3, 6):
# Mypy complains that the signatures overlap (same for relpath below), but things seem to behave correctly anyway.
@overload
def join(path: _StrPath, *paths: _StrPath) -> Text: ... # type: ignore
def join(path: _StrPath, *paths: _StrPath) -> Text: ...
@overload
def join(path: _BytesPath, *paths: _BytesPath) -> bytes: ...
else:
def join(path: AnyStr, *paths: AnyStr) -> AnyStr: ...

@overload
def relpath(path: _BytesPath, start: Optional[_BytesPath] = ...) -> bytes: ... # type: ignore
def relpath(path: _BytesPath, start: Optional[_BytesPath] = ...) -> bytes: ...
@overload
def relpath(path: _StrPath, start: Optional[_StrPath] = ...) -> Text: ...

Expand Down