add types to sys.getrefcount #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,7 +122,7 @@ def getcheckinterval() -> int: ... # deprecated | |||
| def getdefaultencoding() -> str: ... | |||
| def getdlopenflags() -> int: ... # Unix only | |||
| def getfilesystemencoding() -> str: ... # cannot return None | |||
| def getrefcount(object) -> int: ... | |||
| def getrefcount(object: Any) -> int: ... | |||
There was a problem hiding this comment.
Could you rename the argument? E.g. to arg.
Also please do the 2.7 version too.
There was a problem hiding this comment.
Done.
But changing the name of the argument will make a perfect valid python code fail (explicit kwargs)
import sys
sys.getrefcount(object=1)gives
asd2.py:3: error: Unexpected keyword argument "object" for "getrefcount"
hswong3i
pushed a commit
to alvistack/python-typeshed
that referenced
this pull request
May 25, 2025
Fixes python#236 Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getrefcountworks on any object. It nicer to be explicit in stubs.