Make dataclasses availible as a backported third_party library. #2354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 - thanks! |
|
Could you add this to tests/check_consistent.py to make sure that the backport and the stdlib version stay in sync? |
|
Will do
…On Wed, 01 Aug 2018, 16:55 Jelle Zijlstra, ***@***.***> wrote:
Could you add this to tests/check_consistent.py to make sure that the
backport and the stdlib version stay in sync?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2354 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVfr24wYRS_G7eXH7WMc2uPjpWEMpTJks5uMcFWgaJpZM4VqMXz>
.
|
mgilson
reviewed
Aug 18, 2018
|
|
||
| class InitVar(Generic[_T]): ... | ||
|
|
||
| def make_dataclass(cls_name: str, fields: Iterable[Union[str, Tuple[str, type], Tuple[str, type, Field[Any]]]], *, |
There was a problem hiding this comment.
I believe that mypy was complaining to me about this one the other day. I generally run with --strict and mypy is unhappy with the implied Any return value here.
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes python/mypy#5389, and implements the fix suggested by @gvanrossum
I have manually tested the change, and it fixes the issue for me.
I'm not sure if there is a way to write a automated test for the change?
I have not requested permission from the library owner, as I am assuming that this is not necessary for stdlib backports.