Skip to content

Add stdlib/2and3/imghdr stubs #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Add stdlib/2and3/imghdr stubs #2318

merged 1 commit into from
Jul 10, 2018

Conversation

bluetech
Copy link
Contributor

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one request.

def what(file: _File) -> Optional[str]: ...
@overload
def what(file: Any, h: bytes)-> Optional[str]: ...
tests = ... # type: List[Callable[[bytes, BinaryIO], Optional[str]]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use variable annotations instead of type comments?

@bluetech
Copy link
Contributor Author

Updated to use variable annotations.

@JelleZijlstra JelleZijlstra merged commit 0bc98a1 into python:master Jul 10, 2018
@JelleZijlstra
Copy link
Member

Thanks!

yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants