Add support for well_known_types to google/protobuf #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class Error(Exception): ... | ||
| class ParseError(Error): ... | ||
|
|
||
| # This is named 'Any' in the original, but that conflicts with typing.Any, |
There was a problem hiding this comment.
Why don't we from typing import Any as Any_ instead to avoid this?
There was a problem hiding this comment.
Because that would require more changes to the code below (generated by stubgen), all of which uses Any as meaning typing.Any.
gwk
pushed a commit
to gwk/typeshed
that referenced
this pull request
May 29, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2154