fix integration of io with mypy #196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #194 for reference.
So, that should fix mypy tests. Why coping classes around? Because it is the (sadly only) way to do it,
BaseIO
can not inherit bothBinaryIO
because thenTextIOWrapper
would need to redefine some method (by havingTextIO
) but failing because not being compliant withBinaryIO
. Copying seems like the best solution.There is also some issues with mypy itself (should redefine
writelines
in bothTextIO
andBinaryIO
opened here, usingwrite_through
in python 3.2 but it appears only in python 3.3).