Merge style guide from README.md into CONTRIBUTING.md #1696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested changes
Oct 29, 2017
CONTRIBUTING.md
Outdated
| checker, and leave out unnecessary detail: | ||
| * for arguments with a default, use `...` instead of the actual | ||
| default; | ||
| * for arguments with a type and a default, use spaces around the `=`; |
There was a problem hiding this comment.
I think this belongs better in the previous list, since it's purely about style and not about information content.
There was a problem hiding this comment.
That is a good point. I grouped it back in another commit.
JelleZijlstra
approved these changes
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For previous discussions, see PR #1687 and issue #1688.