Update argparse.pyi #1578
Merged
Update argparse.pyi #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argparse.Namespace is also useful as a Bunch
JelleZijlstra
requested changes
Aug 27, 2017
stdlib/2and3/argparse.pyi
Outdated
| @@ -117,6 +117,7 @@ class Action: | |||
| option_string: _Text = ...) -> None: ... | |||
|
|
|||
| class Namespace: | |||
| def __init__(self, **kwargs: Dict[_Text, Any]) -> None: ... | |||
There was a problem hiding this comment.
This means that every keyword argument must be a Dict. I think you want just **kwargs: Any. (That would also fix the Travis failures.)
|
Oh, that makes sense. Thanks for the tip! |
| @@ -117,6 +117,7 @@ class Action: | |||
| option_string: _Text = ...) -> None: ... | |||
|
|
|||
| class Namespace: | |||
| def __init__(self, **kwargs: Any) -> None: ... | |||
| def __getattr__(self, name: _Text) -> Any: ... | |||
| def __setattr__(self, name: _Text, value: Any) -> None: ... | |||
There was a problem hiding this comment.
Looking at the code I noticed it also has def __contains__(self, key: str) -> bool: ...; would you mind adding that?
There was a problem hiding this comment.
Thanks! I'll merge once Travis passes (unless I forget).
JelleZijlstra
approved these changes
Aug 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argparse.Namespace is also useful as a Bunch