Add type annotations for emoji #1506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you ask the maintainer of the library for permission to add stubs on typeshed and link that here? |
third_party/2and3/emoji.pyi
Outdated
|
|
||
| def emojize( | ||
| string: str, | ||
| use_aliases: bool=False, |
There was a problem hiding this comment.
Defaults should always just be ....
|
Ok. I've written the issue carpedm20/emoji#64 and sent an email to author. Hopefully, we'll get a reponce soon enough. |
|
This looks no problem to me. Thanks for the work @asmfreak |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds type annotations for
emojilibrary