Indicate that float() accepts Real objects
#1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contradicts CPython, in `Lib/numbers.py`, because `Real` does not actually inherit from `SupportsFloat`. But it suppresses errors from mypy when passing sub-classes like `fractions.Fraction` to `float()`.
|
Thanks! |
|
This seems very ad-hoc. Why not add SupportsComplex to the Complex class? Also, many place that support float don't declare SupportsFloat -- we really won't get anything near correct coverage of these issues until we have Protocols (PEP 544). |
|
@gvanrossum I basically agree, it was a slightly selfish change for my own convenience, to let me use But I know basically nothing about mypy, so if this should be reverted I've no problem with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contradicts CPython, in
Lib/numbers.py, becauseRealdoes notactually inherit from
SupportsFloat. But it suppresses errors frommypy when passing sub-classes like
fractions.Fractiontofloat().