Skip to content

Update typing.Union and types.UnionType definitions for 3.14 #13740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Mar 29, 2025

@srittau
Copy link
Collaborator

srittau commented Mar 29, 2025

Thanks for contributing! Unfortunately, as outlined in our CONTRIBUTING document we only accept pull requests to the standard library for future Python versions after the first beta version has been released. This is in part to prevent churn in the stubs, and in part because the testing infrastructure for the future version is not yet in place. Please feel free to open a new PR when the first beta version has been released. Alternatively, if this PR is still relevant, you can leave a comment here to reopen it.

@srittau srittau closed this Mar 29, 2025

This comment has been minimized.

@Avasam
Copy link
Collaborator

Avasam commented May 15, 2025

@Viicos Beta 1 has been released! I don't think contributors can re-open their PRs. You can let us know if you'd like us to re-open this or you can create a new PR!

@Viicos
Copy link
Contributor Author

Viicos commented May 15, 2025

Yes happy to have this one reopened.

@srittau srittau reopened this May 15, 2025
@JelleZijlstra
Copy link
Member

I tried this too but ran into some trouble with how type checkers are special-casing these symbols; might need some changes inside type checkers too.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants