Skip to content

builtins.slice: more precise __new__ overloads and defaults for StopT and StepT. #13008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Feb 28, 2025

Conversation

randolf-scholz
Copy link
Contributor

@randolf-scholz randolf-scholz commented Nov 13, 2024

Alternative to #12904, letting step default to start|stop (if intersections are ever added, use start&stop)

randolf-scholz and others added 30 commits October 24, 2024 18:35
Co-authored-by: Alex Waygood <[email protected]>

This comment has been minimized.

This comment has been minimized.

@randolf-scholz randolf-scholz marked this pull request as ready for review November 13, 2024 12:22

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Diff from mypy_primer, showing the effect of this PR on open source code:

mongo-python-driver (https://github.com/mongodb/mongo-python-driver)
- pymongo/synchronous/auth.py:192: error: Argument 1 to "getnameinfo" has incompatible type "tuple[str, int] | tuple[str, int, int, int] | tuple[int, bytes]"; expected "tuple[str, int] | tuple[str, int, int, int]"  [arg-type]
- pymongo/asynchronous/auth.py:195: error: Argument 1 to "getnameinfo" has incompatible type "tuple[str, int] | tuple[str, int, int, int] | tuple[int, bytes]"; expected "tuple[str, int] | tuple[str, int, int, int]"  [arg-type]

urllib3 (https://github.com/urllib3/urllib3)
- test/contrib/test_socks.py:120: error: Incompatible return value type (got "list[tuple[AddressFamily, SocketKind, int, str, tuple[str, int] | tuple[str, int, int, int] | tuple[int, bytes]]]", expected "list[tuple[AddressFamily, SocketKind, int, str, tuple[str, int] | tuple[str, int, int, int]]]")  [return-value]

trio (https://github.com/python-trio/trio)
- src/trio/_socket.py:215: error: Incompatible return value type (got "list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int], tuple[int, bytes]]]]", expected "list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int]]]]")  [return-value]
- src/trio/_socket.py:244: error: Argument 1 to "to_thread_run_sync" has incompatible type "Callable[[Union[bytes, str, None], Union[bytes, str, int, None], int, int, int, int], list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int], tuple[int, bytes]]]]]"; expected "Callable[..., list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int]]]]]"  [arg-type]
- src/trio/_tests/test_socket.py:130: error: Argument 1 to "MonkeypatchedGAI" has incompatible type "Callable[[Union[bytes, str, None], Union[bytes, str, int, None], int, int, int, int], list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int], tuple[int, bytes]]]]]"; expected "Callable[[Union[str, bytes, None], Union[str, bytes, int, None], int, int, int, int], list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int]]]]]"  [arg-type]

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start with this PR as it fixes a few primer hits.

@srittau srittau merged commit be17dc0 into python:main Feb 28, 2025
64 checks passed
mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants