remove redundant methods from _io classes #12761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib/_io.pyi
Outdated
| # Equals the "buffer" argument passed in to the constructor. | ||
| def detach(self) -> _BufferT_co: ... # type: ignore[override] | ||
| # TextIOWrapper's version of seek only supports a limited subset of | ||
| # operations. | ||
| def seek(self, cookie: int, whence: int = 0, /) -> int: ... | ||
|
|
||
| # The C implementation is not a subclass of TextIOWrapper at runtime, |
There was a problem hiding this comment.
The C implementation is the one that virtually all users would use, right? In that case, it would be better to follow the C implementation.
There was a problem hiding this comment.
I wouldn't mind untangling that, but I think that's for another MR. I can remove the note if you'd prefer, it's not terribly important to capture that here right now.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #12755
The
__enter__'s were due to using TypeVar instead of Self originally. I'm not totally sure about the others, but they don't seem necessary anymore.