Fix DatagramRequestHandler.packet type hint. #12563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
DatagramRequestHandler.packet
type hint to bebytes
.typeshed
is currently typing it as asocket
.In Python's stdlib,
packet
is set in the following code located in socketserver.py.self.packet
is the first element in theself.request
tuple which is atypedshed._RequestType
.Additionally, in the
setup()
method shown aboveself.packet
is being passed toBytesIO()
, so it is definitely abytes
object.