Remove ParamSpec for SupportsReplace #12410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Jul 23, 2024
Comment on lines
+10
to
+12
| class _SupportsReplace(Protocol): | ||
| # In reality doesn't support args, but there's no other great way to express this. | ||
| def __replace__(self, *args: _P.args, **kwargs: _P.kwargs) -> Self: ... | ||
| def __replace__(self, *args: Any, **kwargs: Any) -> Self: ... |
There was a problem hiding this comment.
(Can't add this as suggestion.)
class _SupportsReplace(Protocol):
def __replace__(self, **changes: Any) -> Self: ... # changes as passed to replace()There was a problem hiding this comment.
If you look back at the old PR, this doesn't work, since type-checkers will complain if the implementation does have **kwargs, as opposed to supporting any amount of variable key word arguments.
There was a problem hiding this comment.
@srittau Just wanted to follow up on this.
This comment has been minimized.
This comment has been minimized.
|
@srittau Just wanted to follow-up again on this one. |
This comment has been minimized.
This comment has been minimized.
|
@srittau Sorry to double ping here, but was curious if you had any thoughts! |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address Eric's comment here: #12262 (comment)
Accidentally undid this commit before merging.