[requests] Update to 2.32.3 #12060
Merged
[requests] Update to 2.32.3 #12060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `Any` with `Incomplete` in requests.models
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
commented
May 30, 2024
| def build_response(self, req, resp): ... | ||
| def build_response(self, req: PreparedRequest, resp: urllib3.BaseHTTPResponse) -> Response: ... | ||
| def build_connection_pool_key_attributes( | ||
| self, request: PreparedRequest, verify: bool | str, cert: str | tuple[str, str] | None = None |
There was a problem hiding this comment.
According to the implementation, verify can also be None, but the docstring makes me think that is not desired for this method.
JelleZijlstra
approved these changes
Jun 1, 2024
max-muoto
pushed a commit
to max-muoto/typeshed
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
AnywithIncompletein requests.models