Skip to content

regex: functions do not accept any buffer for pattern #11899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2024
Merged

regex: functions do not accept any buffer for pattern #11899

merged 1 commit into from
May 11, 2024

Conversation

hamdanal
Copy link
Contributor

Calling these functions with a bytearray raises TypeError: unhashable type: 'bytearray', calling them with a memoryview raises TypeError: first argument must be a string or compiled pattern

@hamdanal
Copy link
Contributor Author

Also https://github.com/mrabarnett/mrab-regex/blob/be139ffc3a18a7ead6939ea19015dc41e3682ec4/regex_3/regex.py#L509-L519

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau
srittau approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 6565e8a into python:main May 11, 2024
42 checks passed
@hamdanal hamdanal deleted the regex-pattern branch May 11, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamdanal @srittau