ldap3: Connection: auto_bind also supports booleans #11289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier ldap3 versions only accepted booleans as auto_bind values, and they are still supported and used in various places in upstream documentation (e.g. at [0]). [0]: https://ldap3.readthedocs.io/en/latest/bind.html?highlight=auto_bind
|
Diff from mypy_primer, showing the effect of this PR on open source code: mitmproxy (https://github.com/mitmproxy/mitmproxy)
- mitmproxy/addons/proxyauth.py:229: error: Argument "auto_bind" to "Connection" has incompatible type "Literal[True]"; expected "Literal['DEFAULT', 'NONE', 'NO_TLS', 'TLS_BEFORE_BIND', 'TLS_AFTER_BIND']" [arg-type]
- mitmproxy/addons/proxyauth.py:285: error: Argument "auto_bind" to "Connection" has incompatible type "Literal[True]"; expected "Literal['DEFAULT', 'NONE', 'NO_TLS', 'TLS_BEFORE_BIND', 'TLS_AFTER_BIND']" [arg-type]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier ldap3 versions only accepted booleans as auto_bind values, and
they are still supported and used in various places in upstream
documentation (e.g. at 0).