Skip to content

fix __match_args__ attribute name #10813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2023
Merged

fix __match_args__ attribute name #10813

merged 1 commit into from
Oct 1, 2023

Conversation

bzoracler
Copy link
Contributor

>>> import ast
>>> m = ast.parse("type ListOrSet[T] = list[T] | set[T]")
>>> print(m.body[0].__match_args__)
('name', 'type_params', 'value')

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra
Copy link
Member

Thanks, good catch. I wonder if something in CI should validate that the __slots__ match existing attribute names.

@JelleZijlstra JelleZijlstra merged commit 3eb9ff7 into python:main Oct 1, 2023
@bzoracler bzoracler deleted the patch-1 branch October 1, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants