Fix @patch when new is missing
#10459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: streamlit (https://github.com/streamlit/streamlit)
- lib/tests/streamlit/config_test.py:619:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "return_value" [attr-defined]
+ lib/tests/streamlit/config_test.py:619:9: error: "_patch_default_new" has no attribute "return_value" [attr-defined]
- lib/tests/streamlit/config_test.py:621:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "side_effect" [attr-defined]
+ lib/tests/streamlit/config_test.py:621:9: error: "_patch_default_new" has no attribute "side_effect" [attr-defined]
- lib/tests/streamlit/config_test.py:645:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "return_value" [attr-defined]
+ lib/tests/streamlit/config_test.py:645:9: error: "_patch_default_new" has no attribute "return_value" [attr-defined]
- lib/tests/streamlit/config_test.py:647:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "side_effect" [attr-defined]
+ lib/tests/streamlit/config_test.py:647:9: error: "_patch_default_new" has no attribute "side_effect" [attr-defined]
- lib/tests/streamlit/config_test.py:683:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "return_value" [attr-defined]
+ lib/tests/streamlit/config_test.py:683:9: error: "_patch_default_new" has no attribute "return_value" [attr-defined]
- lib/tests/streamlit/config_test.py:685:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "side_effect" [attr-defined]
+ lib/tests/streamlit/config_test.py:685:9: error: "_patch_default_new" has no attribute "side_effect" [attr-defined]
- lib/tests/streamlit/config_test.py:731:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "return_value" [attr-defined]
+ lib/tests/streamlit/config_test.py:731:9: error: "_patch_default_new" has no attribute "return_value" [attr-defined]
- lib/tests/streamlit/config_test.py:733:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "side_effect" [attr-defined]
+ lib/tests/streamlit/config_test.py:733:9: error: "_patch_default_new" has no attribute "side_effect" [attr-defined]
- lib/tests/streamlit/config_test.py:757:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "return_value" [attr-defined]
+ lib/tests/streamlit/config_test.py:757:9: error: "_patch_default_new" has no attribute "return_value" [attr-defined]
- lib/tests/streamlit/config_test.py:759:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "side_effect" [attr-defined]
+ lib/tests/streamlit/config_test.py:759:9: error: "_patch_default_new" has no attribute "side_effect" [attr-defined]
- lib/tests/streamlit/config_test.py:793:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "return_value" [attr-defined]
+ lib/tests/streamlit/config_test.py:793:9: error: "_patch_default_new" has no attribute "return_value" [attr-defined]
- lib/tests/streamlit/config_test.py:795:9: error: "_patch[Union[MagicMock, AsyncMock]]" has no attribute "side_effect" [attr-defined]
+ lib/tests/streamlit/config_test.py:795:9: error: "_patch_default_new" has no attribute "side_effect" [attr-defined]
|
JukkaL
approved these changes
Jul 14, 2023
|
Thank you! |
AlexWaygood
approved these changes
Jul 14, 2023
| class _patch_default_new(_patch[_Mock]): | ||
| @overload | ||
| def __call__(self, func: _TT) -> _TT: ... | ||
| # Can't use the following as ParamSpec is only allowed as last parameter: |
There was a problem hiding this comment.
Suggested change
| # Can't use the following as ParamSpec is only allowed as last parameter: | |
| # Can't use the following as ParamSpec is only allowed as the last parameter to Concatenate[]: |
| assert_type(f_default_new(1), str) | ||
| f_default_new("a") # Not an error due to ParamSpec limitations | ||
| assert_type(f_explicit_new(1), str) | ||
| f_explicit_new("a") # type: ignore[arg-type] |
There was a problem hiding this comment.
Nit: we currently don't use mypy error codes for type: ignores in the test_cases directory: (see rationale in #8083)
Suggested change
| f_explicit_new("a") # type: ignore[arg-type] | |
| f_explicit_new("a") # type: ignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #10457