Skip to content

datetime: Remove unused stubtest allowlist entry for py312 #10277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 12, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jun 7, 2023

I don't quite understand what is the case with __all__ here. So, I want to see the results.
Related python/cpython#104920

This will be fixed automatically when this new commit by @hauntsaninja is released.

@AlexWaygood
Copy link
Member

AlexWaygood commented Jun 21, 2023

@AlexWaygood
Copy link
Member

We're using the latest beta of Python 3.12 in CI now, but the CI is still failing on this PR -- @sobolevn, looks like some updates might need to be made to datetime.pyi?

@sobolevn
Copy link
Member Author

sobolevn commented Jun 23, 2023

Hm, I don't think so:

  1. Source: https://github.com/python/cpython/blob/3.12/Lib/datetime.py#L8-L9 ("date", "datetime", "time", "timedelta", "timezone", "tzinfo", "MINYEAR", "MAXYEAR") (no "UTC")
  2. Stubs: https://github.com/python/typeshed/blob/main/stdlib/datetime.pyi#L8 ("date", "datetime", "time", "timedelta", "timezone", "tzinfo", "MINYEAR", "MAXYEAR" , "UTC")

Looks like python/cpython#104920 was not backported to 3.12.

@AlexWaygood
Copy link
Member

AlexWaygood commented Jun 23, 2023

Looks like python/cpython#104920 was not backported to 3.12.

I've triggered a backport for that PR (python/cpython#106019), but I'll wait a little bit to check that Paul doesn't object before merging it :)

Assuming he doesn't, we can hopefully get it into the next 3.12 beta.

@srittau
Copy link
Collaborator

srittau commented Jun 27, 2023

The backport has now been merged, so this should be fixed in the next beta.

@AlexWaygood AlexWaygood marked this pull request as ready for review July 12, 2023 20:05
@AlexWaygood AlexWaygood changed the title Update datetime.pyi for Python3.12 datetime: Remove unused stubtest allowlist entry for py312 Jul 12, 2023
@AlexWaygood AlexWaygood merged commit f843922 into main Jul 12, 2023
@AlexWaygood AlexWaygood deleted the py312-datetime branch July 12, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants