Skip to content

Noticing stubtest failures #6972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Akuli opened this issue Jan 20, 2022 · 2 comments · Fixed by #6978
Closed

Noticing stubtest failures #6972

Akuli opened this issue Jan 20, 2022 · 2 comments · Fixed by #6978
Labels
project: policy Organization of the typeshed project

Comments

@Akuli
Copy link
Collaborator

Akuli commented Jan 20, 2022

Occasionally the nightly stubtest run fails. About 6 weeks ago, I wrote the following script, which checks whether the last run failed, and if it did, it adds a reminder for me to fix it:

#!/bin/bash
date
url="https://api.github.com/repos/python/typeshed/actions/workflows/stubtest.yml/runs?per_page=1"
if curl "$url" -H "Accept: application/vnd.github.v3+json" | grep failure; then
    echo $(date +'%Y-%m-%d') ONCE "typeshed: checking all stubs with stubtest is failing" >> ~/.tasklist
fi

I set this to run whenever I log in. When I see the reminder in my task list, I usually find the failure on github and create an issue such as #6683, #6501, #6855 or #6971.

This works, but relying on a script running on one maintainer's personal computer doesn't feel right. We could automate creating the issue, but the catch is that we will get a spam of several issues if stubtest is broken for several days: https://github.community/t/create-an-issue-case-the-workflow-fails/17247

@srittau srittau added the project: policy Organization of the typeshed project label Jan 20, 2022
@srittau
Copy link
Collaborator

srittau commented Jan 20, 2022

I'm fine with this. If we don't manage to fix the problem within a day, we can always disable the workflow quite easily via the menu on https://github.com/python/typeshed/actions/workflows/stubtest.yml.

Also, according to this page, exactly one maintainer gets email notifications about failed runs. It's not me at the moment, though.

@JelleZijlstra
Copy link
Member

I get the emails. I've been remiss in fixing them though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: policy Organization of the typeshed project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants