Skip to content

stubtest is failing for mock #6683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Akuli opened this issue Dec 24, 2021 · 6 comments · Fixed by #6685
Closed

stubtest is failing for mock #6683

Akuli opened this issue Dec 24, 2021 · 6 comments · Fixed by #6685

Comments

@Akuli
Copy link
Collaborator

Akuli commented Dec 24, 2021

https://github.com/python/typeshed/runs/4622929362?check_suite_focus=true

@srittau
Copy link
Collaborator

srittau commented Dec 24, 2021

Interesting, there has been no new release. Maybe we could just remove mock as all supported Python 3 include unittest.mock, of which this is a backport. For Python 2, types-mock 4.0.4 is still available.

@srittau
Copy link
Collaborator

srittau commented Dec 24, 2021

Actually, this does not support Python 2.

@srittau
Copy link
Collaborator

srittau commented Dec 24, 2021

And it offers features from newer Python versions to older ones, although I'm not sure there have been many improvements to unittest.mock since 3.6.

@srittau
Copy link
Collaborator

srittau commented Dec 24, 2021

I'll work on a fix.

@srittau srittau linked a pull request Dec 24, 2021 that will close this issue
@hauntsaninja
Copy link
Collaborator

(Probably just from the 0.930 upgrade? CI has third party git skipping logic)

@srittau
Copy link
Collaborator

srittau commented Dec 24, 2021

The problem is that stubtest fails after the first failing distribution. Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants