Skip to content

Third-party stubs: allow three-element version numbers #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srittau opened this issue Sep 1, 2021 · 3 comments · Fixed by #5995
Closed

Third-party stubs: allow three-element version numbers #5992

srittau opened this issue Sep 1, 2021 · 3 comments · Fixed by #5995
Labels
project: policy Organization of the typeshed project

Comments

@srittau
Copy link
Collaborator

srittau commented Sep 1, 2021

For some calver packages that use a YYYY.MM.DD format it makes sense to allow three-element versions in METADATA.toml's version field, meaning four-element versions in the generated types packages (e.g. types-foo 2021.08.21.3). I think we should allow this.

Cc @JukkaL
@srittau srittau added the project: policy Organization of the typeshed project label Sep 1, 2021
srittau added a commit to srittau/typeshed that referenced this issue Sep 2, 2021
@srittau
Allow three-component third-party versions
80cc5d4 
Closes: python#5992
@srittau srittau mentioned this issue Sep 2, 2021
Merged
@srittau
Copy link
Collaborator Author

srittau commented Sep 2, 2021

certifi is one of the stubs where this is needed. I though there was another one, but I can't remember what it was and can't find it anymore.

@hauntsaninja
Copy link
Collaborator

Grepping years says maybe pytz?

@srittau
Copy link
Collaborator Author

srittau commented Sep 2, 2021

pytz seems to use some calver variant, but only two components.

JelleZijlstra pushed a commit that referenced this issue Sep 19, 2021
@srittau
Allow three-component third-party versions (#5995)
0506182 
Closes: #5992
@srittau srittau mentioned this issue Sep 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project: policy Organization of the typeshed project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow three-component third-party versions srittau/typeshed
2 participants
@srittau @hauntsaninja