Stubs for requests are too restrictive

[gvanrossum]

The 3rd party requests library is too dynamic for static typing, and its maintainers don't care about static typing. (There was previous discussion about this; can someone look up the issue?)

We still have stubs to guide users away from the most egregious issues, but the stubs are too restrictive. Maybe we should be satisfied with all methods and functions being(*args: Any, **kwds: Any) -> Any?

[gvanrossum]

At the same time they are incomplete, some submodules (e.g. packages) have no stubs at all, and that causes errors in mypy despite --ignore-missing-modules.

[OJFord]

There's also an issue using requests.codes, e.g. codes.accepted will cause mypy to complain that:

error: "LookupDict" has no attribute "accepted"

This is true enough, but requests.structures.LookupDict hacks __getitem__ to allow it; it's much cleaner than codes['accepted'], and idiomatic as far as I'm aware.

(Aside: the reason code names are not actually defined is that in some cases there are a few aliases, and presumably the authors preferred to list aliases once in a 'lookup dict' than to def them all.)

[gvanrossum]

Is this a limited set of attributes? Because then we can just add them all to the stub.

[OJFord]

Yes, but it is quite big. (A laborious rather than complex task.) Here's an excerpt:

https://github.com/requests/requests/blob/19919b44c4af95f125704c902acecdf83d70a3e4/requests/status_codes.py#L54-L61

Edit: Or not an excerpt then - apparently code previews don't work across repos.

[gvanrossum]

So write a one-off script that prints the stuff you have to paste into the stub. Alternatively, you can add a `__getattr__` that returns `Any`.

…

On Sat, Nov 25, 2017 at 8:18 AM, Ollie Ford ***@***.***> wrote: Yes, but it is quite big. (A laborious rather than complex task.) Here's an excerpt: https://github.com/requests/requests/blob/19919b44c4af95f125704c902acecd f83d70a3e4/requests/status_codes.py#L54-L61 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1093 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACwrMraZEpxBMBFVhsXJTqmafJtyfp66ks5s6D3hgaJpZM4Mo6yY> .

-- --Guido van Rossum (python.org/~guido)

[hauntsaninja]

This issue is pretty stale; several improvements have been made to requests' stubs and it's used enough that most egregious false positives are probably fixed.