Skip to content

Commit db7df55

Browse files
committed
[django-filter] Various minor fixes
1 parent 8956aaf commit db7df55

File tree

7 files changed

+22
-10
lines changed

7 files changed

+22
-10
lines changed

stubs/django-filter/@tests/stubtest_allowlist.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ django_filters.RemovedInDjangoFilter25Warning
88
django_filters.fields.BaseCSVWidget.surrogate
99
django_filters.fields.CSVWidget.__init__
1010
django_filters.fields.DJANGO_50
11+
django_filters.filters.__all__
1112
django_filters.filters.Filter.__init__
1213
django_filters.filters.NumberFilter.get_max_validator
1314
django_filters.filterset.BaseFilterSet.filter_for_field
1415
django_filters.filterset.FilterSet.base_filters
1516
django_filters.filterset.FilterSet.declared_filters
16-
django_filters.models
1717
django_filters.rest_framework.DjangoFilterBackend
1818
django_filters.rest_framework.Filter.__init__
1919
django_filters.rest_framework.FilterSet.base_filters

stubs/django-filter/django_filters/__init__.pyi

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from typing import Any
22

3-
from . import rest_framework as rest_framework
43
from .filters import *
54
from .filterset import FilterSet as FilterSet
65

stubs/django-filter/django_filters/fields.pyi

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
from typing import Any
1+
from typing import Any, TypeVar
22

33
from django import forms
4+
from django.db.models import Model
45

56
from .conf import settings as settings
67
from .constants import EMPTY_VALUES as EMPTY_VALUES
@@ -13,6 +14,8 @@ from .widgets import (
1314
RangeWidget as RangeWidget,
1415
)
1516

17+
_M = TypeVar("_M", bound=Model)
18+
1619
class RangeField(forms.MultiValueField):
1720
widget: Any = ...
1821
def __init__(self, fields: Any | None = ..., *args: Any, **kwargs: Any) -> None: ...
@@ -85,9 +88,9 @@ class MultipleChoiceField(ChoiceIteratorMixin, forms.MultipleChoiceField):
8588
empty_label: Any = ...
8689
def __init__(self, *args: Any, **kwargs: Any) -> None: ...
8790

88-
class ModelChoiceField(ChoiceIteratorMixin, forms.ModelChoiceField):
91+
class ModelChoiceField(ChoiceIteratorMixin, forms.ModelChoiceField[_M]):
8992
iterator: Any = ...
9093
def to_python(self, value: Any): ...
9194

92-
class ModelMultipleChoiceField(ChoiceIteratorMixin, forms.ModelMultipleChoiceField):
95+
class ModelMultipleChoiceField(ChoiceIteratorMixin, forms.ModelMultipleChoiceField[_M]):
9396
iterator: Any = ...

stubs/django-filter/django_filters/filters.pyi

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
from typing import Any, Callable
1+
from _typeshed import Incomplete
2+
from collections.abc import Callable
3+
from typing import Any
24

35
class Filter:
46
creation_counter: int = ...
@@ -20,7 +22,7 @@ class Filter:
2022
**kwargs: Any,
2123
) -> None: ...
2224
def get_method(self, qs: Any): ...
23-
method: Callable = ...
25+
method: Callable[..., Incomplete] = ...
2426
label: Any = ...
2527
@property
2628
def field(self): ...

stubs/django-filter/django_filters/models.pyi

Whitespace-only changes.

stubs/django-filter/django_filters/views.pyi

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from _typeshed import Incomplete
12
from typing import Any
23

34
from django.views.generic import View
@@ -19,7 +20,7 @@ class FilterMixin(metaclass=FilterMixinRenames):
1920
def get_filterset_kwargs(self, filterset_class: Any): ...
2021
def get_strict(self): ...
2122

22-
class BaseFilterView(FilterMixin, MultipleObjectMixin, View):
23+
class BaseFilterView(FilterMixin, MultipleObjectMixin[Incomplete], View):
2324
filterset: Any = ...
2425
object_list: Any = ...
2526
def get(self, request: Any, *args: Any, **kwargs: Any): ...

stubs/django-filter/django_filters/widgets.pyi

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,25 @@
1+
from _typeshed import Incomplete
12
from typing import Any
3+
from typing_extensions import TypeAlias
24

35
from django import forms
46
from django.forms.renderers import BaseRenderer
57
from django.utils.safestring import SafeText
68

7-
_OptAttrs = dict[str, Any]
9+
_OptAttrs: TypeAlias = dict[str, Any]
810

911
class LinkWidget(forms.Widget):
1012
choices: Any = ...
1113
def __init__(self, attrs: Any | None = ..., choices: Any = ...) -> None: ...
1214
data: Any = ...
1315
def value_from_datadict(self, data: Any, files: Any, name: Any): ...
1416
def render( # type: ignore[override]
15-
self, name: str, value: Any, attrs: _OptAttrs | None = ..., choices: tuple = ..., renderer: BaseRenderer | None = ...
17+
self,
18+
name: str,
19+
value: Any,
20+
attrs: _OptAttrs | None = ...,
21+
choices: tuple[Incomplete, ...] = ...,
22+
renderer: BaseRenderer | None = ...,
1623
) -> SafeText: ...
1724
def render_options(self, choices: Any, selected_choices: Any, name: Any): ...
1825
def render_option(self, name: Any, selected_choices: Any, option_value: Any, option_label: Any): ...

0 commit comments

Comments
 (0)