Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

Vs2010 compilation support (Python 3.3/3.4 support) #47

Merged
merged 4 commits into from
Jul 18, 2017

Conversation

emmatyping
Copy link
Member

MSVC 9's weird C99 implementation means that identifiers must be declared at the beginning of a scope. This refactors the code to support that. There are no functional changes to the parsing. I mostly did this out of an interest to see how hard it would be, turns out pretty simple 😄

This should also work for Python 3.3 (I can add it to the build matrix if desired).

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@ddfisher
Copy link
Collaborator

This looks great! If it's compatible with 3.3 as well, please add that to the build matrix too (so appveyor will build wheels for it). The last sentence of the first paragraph in the readme mentions which Python versions we support -- could you update that here too?

Also, please do the CLA dance -- we're trying to keep this repository fully PSF CLA signed. Thanks!

@emmatyping
Copy link
Member Author

Okay, I made those two changes. I signed the CLA yesterday, but my bpo does not show it as accepted yet... if I need to do anything else, let me know!

@emmatyping emmatyping changed the title Vs2010 compilation support (Python 3.4 support) Vs2010 compilation support (Python 3.3/3.4 support) Jul 17, 2017
@emmatyping
Copy link
Member Author

BPO is now showing my CLA as signed, I believe if you remove the label, it should check again?

@ddfisher
Copy link
Collaborator

Thanks!

@ddfisher ddfisher merged commit ae5c356 into python:master Jul 18, 2017
@emmatyping
Copy link
Member Author

Glad to help! Now to add support in Mypy :)

webknjaz added a commit to aio-libs/multidict that referenced this pull request Aug 25, 2017
This reverts commit b177b76.

mypy now supports Python 3.3/3.4 under Windows

Ref: python/typed_ast#46
Ref: python/typed_ast#47
@webknjaz
Copy link
Contributor

@ddfisher is it possible to release it to PYPI?

P.S. BTW, it's possible to configure automatic deployment to PYPI from Travis CI on tag push. Are you interested in such automation? I could make a PR.

@webknjaz
Copy link
Contributor

Oh.. Now I see it's released, it's just mypy dependency restriction.

tbbharaj pushed a commit to tbbharaj/typed_ast that referenced this pull request Dec 6, 2021
Update bundled lz4 lib files to v1.8.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants