-
-
Notifications
You must be signed in to change notification settings - Fork 54
Vs2010 compilation support (Python 3.3/3.4 support) #47
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
This looks great! If it's compatible with 3.3 as well, please add that to the build matrix too (so appveyor will build wheels for it). The last sentence of the first paragraph in the readme mentions which Python versions we support -- could you update that here too? Also, please do the CLA dance -- we're trying to keep this repository fully PSF CLA signed. Thanks! |
Okay, I made those two changes. I signed the CLA yesterday, but my bpo does not show it as accepted yet... if I need to do anything else, let me know! |
BPO is now showing my CLA as signed, I believe if you remove the label, it should check again? |
Thanks! |
Glad to help! Now to add support in Mypy :) |
This reverts commit b177b76. mypy now supports Python 3.3/3.4 under Windows Ref: python/typed_ast#46 Ref: python/typed_ast#47
@ddfisher is it possible to release it to PYPI? P.S. BTW, it's possible to configure automatic deployment to PYPI from Travis CI on tag push. Are you interested in such automation? I could make a PR. |
Oh.. Now I see it's released, it's just mypy dependency restriction. |
Update bundled lz4 lib files to v1.8.0
MSVC 9's weird C99 implementation means that identifiers must be declared at the beginning of a scope. This refactors the code to support that. There are no functional changes to the parsing. I mostly did this out of an interest to see how hard it would be, turns out pretty simple 😄
This should also work for Python 3.3 (I can add it to the build matrix if desired).